Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to reuse existing search term #22148

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

glassez
Copy link
Member

@glassez glassez commented Jan 11, 2025

The search pattern text reflects that of the current search tab, unless it is manually edited.
The edited search pattern can be reset by double-clicking on one of the tabs.

The alternative option @bartonnen suggested is to simply follow the current tab regardless of whether the pattern has been edited or not. This behavior seems undesirable to me.

@glassez glassez added Search engine Issues related to the search engine/search plugins functionality GUI GUI-related issues/changes labels Jan 11, 2025
@glassez glassez added this to the 5.1 milestone Jan 11, 2025
@glassez glassez requested a review from a team January 11, 2025 14:50
@thalieht
Copy link
Contributor

Dunno if it's caused by this PR: Crash when dragging and dropping a tab outside the tab bar with the right click (can't reproduce with left)

1 SearchJobWidget::status   searchjobwidget.cpp 248 0x555555fc3f70 
2 SearchWidget::showTabMenu searchwidget.cpp    349 0x555555fd18e4 
3 SearchWidget::eventFilter searchwidget.cpp    189 0x555555fd017c 

@glassez
Copy link
Member Author

glassez commented Jan 11, 2025

Dunno if it's caused by this PR

Caused by #22122.
Should be fixed now.

@glassez glassez merged commit 99adb16 into qbittorrent:master Jan 13, 2025
14 checks passed
@glassez glassez deleted the reuse-search-term branch January 13, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes Search engine Issues related to the search engine/search plugins functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants