Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Go Snippets #31

Merged
merged 10 commits into from
Sep 9, 2024
Merged

docs: Go Snippets #31

merged 10 commits into from
Sep 9, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Sep 3, 2024 •
edited
Loading

PREVIEW

NOTE

The fern/apis files are auto generated.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

🌿 Preview your docs: https://qdrant-preview-ee388e86-e3dc-486a-9b07-af4ab36122ab.docs.buildwithfern.com

@Anush008 Anush008 mentioned this pull request Sep 3, 2024
Merged
6 tasks
Robert-Stam
Robert-Stam reviewed Sep 4, 2024
View reviewed changes
Copy link

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remark, this applies to the majority of code.

IMO It's a bad idea to ignore an error in a sample, customers will copy-paste some of the snippets and will not add it (unless they have configured a linter which detect it).

@Anush008
Copy link
Member Author

Anush008 commented Sep 4, 2024

I thought of checking the error.
But ignored it to keep the snippets a little concise.

@Robert-Stam, how about we just panic with the error?

Robert-Stam
Robert-Stam reviewed Sep 4, 2024
View reviewed changes
Copy link

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

Robert-Stam
Robert-Stam approved these changes Sep 9, 2024
View reviewed changes
Copy link

@Robert-Stam Robert-Stam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anush008 Anush008 merged commit b7a67b2 into main Sep 9, 2024
@Anush008 Anush008 deleted the go branch September 9, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-Stam Robert-Stam Robert-Stam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anush008 @Robert-Stam