Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improved cURL snippets #32

Merged
merged 6 commits into from
Sep 12, 2024
Merged

docs: Improved cURL snippets #32

merged 6 commits into from
Sep 12, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Sep 10, 2024

PREVIEW

I have tested the examples.

NOTE

  • The fern/apis files are auto-generated.

Copy link

github-actions bot commented Sep 10, 2024

@davidmyriel
Copy link
Collaborator

Looks good, so this is a permanent override?

@davidmyriel davidmyriel self-assigned this Sep 10, 2024
@davidmyriel davidmyriel removed their assignment Sep 10, 2024
@Anush008
Copy link
Member Author

Looks good, so this is a permanent override?

I didn't get it.

@Anush008
Copy link
Member Author

@davidmyriel, @mrscoopers Good to merge?

@mrscoopers
Copy link

Should we worry about examples of search where limit > 1, but we show POST with one example, or it's intuitive? I don't have an opinion here

@Anush008
Copy link
Member Author

but we show POST with one example,

Do you mean a response with 1 result?

@Anush008
Copy link
Member Author

I just tried to set the limit to 1 in all the snippets.
But I think that won't look right either. Since we usually do the top few results.
So I propose to keep it as is.

@mrscoopers
Copy link

Okay, then lgtm, thank you for such a hard work!

@Anush008 Anush008 merged commit 6c91ce0 into main Sep 12, 2024
@Anush008 Anush008 deleted the curl branch September 12, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants