Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show raster row/column of clicked point in identify results #8764

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Jan 5, 2024

Fixes #8500
I believe that such 'small details' should be mentioned in the 'Working with Raster' chapter, but I'm not sure how to incorporate them into that chapter. I would like to hear suggestions and opinions on this.

@DelazJ
Copy link
Collaborator

DelazJ commented Jan 7, 2024

Interesting remark. The identify tool description is quite vector centered right now despite it can be used also with raster, mesh or point cloud. We could move/create a section for results dialog (and format specifics) to each data type chapter, leaving the common how-to parts and options description in the general tools chapter.
About where to place such info in the raster chapter: probably along with the properties because I expect the analysis page to go when the raster catalog tool gets removed (according to QEP 271), and georeferencer should move out from raster chapter. We could have an intro section as done for mesh/point cloud/tiles formats (why not?) and interacting with raster using the identifier could be an element...
This location could be applied to mesh and point cloud also, and for vector, maybe should it go to attribute table/forms page (?).

Just a rough idea (unfortunately not resulting in a single line PR 😄) and I'm open to all options...

@DelazJ DelazJ added Tools Generic widgets available in many dialogs (intro/general tools) backport release_3.34 On merge create a backported pull request to 3.34 labels Jan 22, 2024
@selmaVH1
Copy link
Collaborator Author

About where to place such info in the raster chapter: probably along with the properties because I expect the analysis page to go when the raster catalog tool gets removed (according to QEP 271), and georeferencer should move out from raster chapter. We could have an intro section as done for mesh/point cloud/tiles formats (why not?) and interacting with raster using the identifier could be an element...

I have added the "Introduction to Raster Data" chapter and provided details about the Identify tool. I will create new PRs for point cloud, mesh, and vector data.

docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
Supported formats include GeoTIFF, Erdas Imagine, ArcInfo ASCII Grid, and many others.
See more at :ref:`opening_data`.

**Worth knowing**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put emphasis on this subject

Suggested change
**Worth knowing**
Identifying raster cells
========================

and I wonder now if this should be here or after the "properties" block

@@ -1121,6 +1121,9 @@ default it will display the following information:
closest vertex (and ``Z``/``M`` if applicable)
* if you click on a curved segment,
the radius of that section is also displayed.
* if you use :guilabel:`Identify features` on a raster layer,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refs comments on #8864

Comment on lines 23 to 28
* Select the raster layer in the Layers panel.
* Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
* Click on the point in the raster layer that you want to identify.

The Identify Results panel will open and display information about the clicked point.
For raster layers, this includes the row and column of the clicked point.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Select the raster layer in the Layers panel.
* Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
* Click on the point in the raster layer that you want to identify.
The Identify Results panel will open and display information about the clicked point.
For raster layers, this includes the row and column of the clicked point.
#. Select the raster layer in the Layers panel.
#. Click on the :guilabel:`Identify features` tool in the toolbar or press :kbd:`Ctrl+Shift+I`.
#. Click on the point in the raster layer that you want to identify.
The Identify Results panel will open and display information about the clicked point.
For raster layers, this includes the row and column of the clicked point.

and let's mention all particular information people should expect here

docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
@@ -1,6 +1,33 @@
.. index:: Raster, Layer properties
.. _raster_properties_dialog:

***************************
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is weird that the build passes with two identical topmost underlines (i.e. page title) in the same file. Anyway the generated HTML is worth a look and you might need to review the sectioning here. E.g. we usually have a table of content displayed just below the page title; here it might be under raster properties section, far below in the page.

docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
@@ -1,9 +1,43 @@
.. index:: Raster, Layer properties

**************************
Intoduction to Raster Data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Intoduction to Raster Data
Introduction to Raster Data

but if this is the top title I don't know if "introduction" is the most suitable for the addressed topics. Introduction is just for the first two paragraphs. that said, I have no suggestion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree... Is it possible to retain the text but remove the sectioning (title), if that makes sense? I was considering removing it entirely...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming I understood correctly, I'd find weirder to have a new chapter/page that starts with no title.

docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
Comment on lines 27 to 34
Raster data can be stored in serval supported formats, including:

* GeoTIFF
* ERDAS Imagine
* ArcInfo ASCII Grid
* PostGIS Raster and others.

See more at :ref:`opening_data`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Raster data can be stored in serval supported formats, including:
* GeoTIFF
* ERDAS Imagine
* ArcInfo ASCII Grid
* PostGIS Raster and others.
See more at :ref:`opening_data`.
Raster data can be stored in several supported formats, including GeoTIFF,
ERDAS Imagine, ArcInfo ASCII Grid, PostGIS Raster and others...
See more at :ref:`opening_data`.

Raster Properties Dialog
************************
========================

.. only:: html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading my previous comment it was probably not clear but the TOC should be moved up, under the top title, to catch all sections of the page. and not stay in the middle of the page.

docs/user_manual/introduction/general_tools.rst Outdated Show resolved Hide resolved
docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
docs/user_manual/working_with_raster/raster_properties.rst Outdated Show resolved Hide resolved
@DelazJ DelazJ merged commit df628da into qgis:master Feb 29, 2024
3 checks passed
DelazJ added a commit that referenced this pull request Feb 29, 2024
[Backport release_3.34] Show raster row/column of clicked point in identify results (backports #8764)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release_3.34 On merge create a backported pull request to 3.34 Tools Generic widgets available in many dialogs (intro/general tools)
Projects
Development

Successfully merging this pull request may close these issues.

Show raster row/column of clicked point in identify results (Request in QGIS)
2 participants