-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix doctests by using airports layer in epsg4326 instead of epsg2964. #9256
base: master
Are you sure you want to change the base?
Attempt to fix doctests by using airports layer in epsg4326 instead of epsg2964. #9256
Conversation
…f epsg2964. Use geopackage airports layer (epsg4326) to avoid ambiguous reprojection warning of previously used Alaska scoped airports layer (epsg2964) when adding it programmatically to a vanilla qgis project during doctest. We do not simply reproject the layer, because the alaska airports crs is mentioned mutliple times in the codebase and streamlining the whole cookbook is out of scope for this PR.
@selmaVH1 could you please trigger the doctest workflow to see if it passes? If not, the whole PR is pointless. If it passes a few times in a row, a priority review/merge could benefit all other PRs. Cheers! |
Cool thanks! The workflow failed, but not due to failing tests (which is good) but due to a segfault after running the tests (which is bad). Link. I am not sure what this is about and how it is connected to my changes. If anybody has an idea, ping me. From failed workflow run logs:
|
…nto fix_doctest_by_using_epsg4326_dataset_instead_of_epsg2964
Hi @folinimarc, thank you for your work on this! I know that airport.shp has been part of the sample data for a long time, and while I'm not entirely sure, I don't think it has previously caused issues or doctest failures. But I do support preferring geopackage over shapefile. @timlinux, if you have time to review this PR, your input would be very helpful. Thanks! |
Fixes #9255
This is an attempt to fix the flaky doctests behavior, only actual workflow runs on the Github agent will provide certainty.
Primary changes
Secondary changes