-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[server] Add WMS parameter value to request only maptip for HTML feature info response #55823
Conversation
33f56c7
to
72b2438
Compare
…eature info response
72b2438
to
f4a44dc
Compare
tests/testdata/qgis_server/wms_getfeatureinfo-html-only-with-maptip-raster.txt
Show resolved
Hide resolved
@pathmapper A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
Any chance to get this in for 3.36? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor comments.
@pathmapper |
This is a proposal to add a new value
HTML_FI_ONLY_MAPTIP
for the existing WMS vendor parameterWITH_MAPTIP
.If set, the feature info HTML response includes only the maptip, which gives full control over the HTML response using e.g. the built-in maptip editor which has a nice preview since #52420 and also got other improvements in #54764.
This aims to be fully backward compatible while closing #20601.
Tests included.