Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[attribute form] Add parent feature scope when adding/editing a child feature through the relation editor widget #57271

Merged
merged 4 commits into from
Jun 3, 2024
Merged

[attribute form] Add parent feature scope when adding/editing a child feature through the relation editor widget #57271

merged 4 commits into from
Jun 3, 2024

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Apr 29, 2024 •
edited by m-kuhn
Loading

Description

This PR provides a useful current_parent_* scope when adding and editing child features through the attribute form's relation editor widget.

For feature addition, it comes in extremely handy when the parent feature is also being added. In this case, the parent feature itself can't be retrieved (since it hasn't even been added to the edit buffer), nor can its attributes or geometry.

Fixes #48915.

Sponsored by Hansestadt Herford

@nirvn nirvn added Requires Tests! Waiting on the submitter to add unit tests before eligible for merging Feature labels Apr 29, 2024
@github-actions github-actions bot added this to the 3.38.0 milestone Apr 29, 2024
@uclaros
Copy link
Contributor

uclaros commented Apr 29, 2024

Does this fix #48915 then? (... and also properly fix #40194 ?)

@nirvn nirvn changed the title Current parent [attribute form] Add parent feature scope when adding/editing a child featur through the relation editor widget Apr 29, 2024
@nirvn nirvn removed the Requires Tests! Waiting on the submitter to add unit tests before eligible for merging label Apr 29, 2024
@nirvn
Copy link
Contributor Author

nirvn commented Apr 30, 2024

@uclaros , it does implement what's requested in #48915 yes :)

@nirvn nirvn closed this Apr 30, 2024
@nirvn nirvn reopened this Apr 30, 2024
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 15, 2024
@nyalldawson nyalldawson added the Freeze Exempt Feature Freeze exemption granted label May 17, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label May 18, 2024
@nirvn nirvn changed the title [attribute form] Add parent feature scope when adding/editing a child featur through the relation editor widget [attribute form] Add parent feature scope when adding/editing a child feature through the relation editor widget May 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 96a711a)

@nirvn nirvn force-pushed the current_parent branch 2 times, most recently from 40804d1 to 9b2d1db Compare June 1, 2024 10:04
@nirvn nirvn force-pushed the current_parent branch 2 times, most recently from 4ed53ef to 64ed3f3 Compare June 3, 2024 02:21
@nirvn nirvn enabled auto-merge June 3, 2024 04:14
@nirvn nirvn merged commit 2c38dc8 into qgis:master Jun 3, 2024
29 of 30 checks passed
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Jun 18, 2024
@qgis-bot
Copy link
Collaborator

@nirvn

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Milestone
3.38.0
Development

Successfully merging this pull request may close these issues.

Enable opportunities to get unsaved data of parent features in child-features
5 participants
@nirvn @uclaros @qgis-bot @nyalldawson @zacharlie