Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Qt6 builds based on vcpkg #57414

Closed
wants to merge 43 commits into from
Closed

Windows Qt6 builds based on vcpkg #57414

wants to merge 43 commits into from

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented May 13, 2024

Description

Refs qgis/QGIS-Enhancement-Proposals#292

This adds windows builds with Qt6, based on vcpkg dependencies.

The features WITH_BINDINGS, WITH_3D and WITH_GUI are supported and appropriately enable or disable building the required dependencies. Feature dependencies for server, opencl and quick are prepared but not yet wired.

Python support is consumed from https://github.com/open-vcpkg/python-registry/ . This is currently focused on shipping python dependencies that contain native code (dll's). Other dependencies can be installed using pip.

It is currently based on Qt 6.7.0.

Various Qt6 compatibility patches have been ported from #56980 and #56841 (QGIS code is now wchar / unicode aware for Qt6, external dependencies are patched to make them build).

TODO:

  • Create an SDK to make local development easier
  • Expand the developer documentation to make it easy to get started with local windows development
  • Unvendor at least one "external" dependency into an overlay port, this will reduce build time and make it clear which version of external dependencies we want and what patches we added on top.
  • Install psycopg2 (and other python dependencies that should be shipped)
  • Check why some exes are installed in top level instead of bin

More ideas:

  • Eventually use X_VCPKG_APPLOCAL_DEPS_INSTALL instead of blindly copying all .dll's, probably in a followup PR

@github-actions github-actions bot added this to the 3.38.0 milestone May 13, 2024
@nyalldawson
Copy link
Collaborator

Nice work @m-kuhn !

Could you adapt the logic from https://github.com/qgis/QGIS/blob/master/.github/workflows/mingw64.yml#L97 to tag the artifact with the corresponding pr number and sha, and then update https://github.com/qgis/QGIS/blob/master/.github/workflows/build_artifact_comment.yml#L5 so that we get a PR comment with a direct link to download the qt6 artifacts?

Copy link

github-actions bot commented May 13, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit ffedc33)

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 23, 2024
@m-kuhn m-kuhn removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Jul 23, 2024
@qgis qgis deleted a comment from github-actions bot Jul 25, 2024
Copy link

github-actions bot commented Aug 9, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 9, 2024
Copy link

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Aug 17, 2024
@m-kuhn m-kuhn reopened this Aug 17, 2024
@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 17, 2024
@m-kuhn
Copy link
Member Author

m-kuhn commented Aug 17, 2024

I will get back to this asap

Copy link

github-actions bot commented Sep 1, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 1, 2024
Copy link

github-actions bot commented Sep 9, 2024

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 21 days. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the QGIS project can do to help push this PR forward please let us know how we can assist.

@github-actions github-actions bot closed this Sep 9, 2024
kannes pushed a commit to kannes/qgis-qt6-xml-order that referenced this pull request Sep 12, 2024
Using the windows executable from
https://github.com/qgis/QGIS/actions/runs/9731000236 of
qgis/QGIS#57414

The .lyr file was not "loaded" per se, but used and with the loaded
layer then a new .lyr was exported.
kannes pushed a commit to kannes/qgis-qt6-xml-order that referenced this pull request Sep 12, 2024
Using the windows executable from
https://github.com/qgis/QGIS/actions/runs/9731000236 of
qgis/QGIS#57414

The .lyr file was not "loaded" per se, but used and with the loaded
layer then a new .lyr was exported.
kannes pushed a commit to kannes/qgis-qt6-xml-order that referenced this pull request Sep 12, 2024
…rtualbox)

Loaded QGIS 3.34.10 with Qt 5.15.13 (Windows), re-saved in QGIS c53d416c
with Qt 6.7.0 (Windows, Virtualbox)

Using the windows executable from
https://github.com/qgis/QGIS/actions/runs/9731000236 of
qgis/QGIS#57414

The .lyr file was not "loaded" per se, but used and with the loaded
layer then a new .lyr was exported.
@m-kuhn m-kuhn deleted the windows-qt6 branch October 7, 2024 15:26
@m-kuhn m-kuhn mentioned this pull request Oct 7, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants