Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add message to QGIS status bar on selection of vertices #58811

Merged
merged 7 commits into from
Oct 25, 2024

Conversation

JanCaha
Copy link
Contributor

@JanCaha JanCaha commented Sep 20, 2024

Description

Display message in status bar when vertices of Mesh are selected.

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 7e0abb4)

@uclaros uclaros added the Mesh Related to general mesh layer handling (not specific data formats) label Sep 20, 2024
Copy link
Contributor

@uclaros uclaros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Also keep in mind that once #58795 gets merged, QgsDistanceArea::measureLine() might throw a QgsCsException which will need to be handled.

{
QgsDistanceArea distArea = QgsDistanceArea();
distArea.setSourceCrs( mCurrentLayer->crs(), QgsProject::instance()->transformContext() );
distArea.setEllipsoid( QgsProject::instance()->ellipsoid() );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to only set the ellipsoid for geographic crses, otherwise skip it so distArea it will calculate a cartesian distance for projected crses

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I think this is correct as is. If users need purely cartesian distances then they should set the project ellipsoid to "none" accordingly.

src/app/mesh/qgsmaptooleditmeshframe.cpp Outdated Show resolved Hide resolved
src/app/mesh/qgsmaptooleditmeshframe.h Outdated Show resolved Hide resolved
src/app/mesh/qgsmaptooleditmeshframe.cpp Outdated Show resolved Hide resolved
@uclaros uclaros added the Frozen Feature freeze - Do not merge! label Sep 20, 2024
JanCaha and others added 4 commits September 20, 2024 13:50
use project distance units

Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
make const

Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
cons function

Co-authored-by: Stefanos Natsis <uclaros@gmail.com>
@nyalldawson
Copy link
Collaborator

Look ok for you @uclaros ?

@nyalldawson nyalldawson removed the Frozen Feature freeze - Do not merge! label Oct 25, 2024
@nyalldawson nyalldawson merged commit 8a93c2d into qgis:master Oct 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mesh Related to general mesh layer handling (not specific data formats)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants