Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate "post sticky comment" logic #58983

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Isolate "post sticky comment" logic #58983

merged 2 commits into from
Oct 6, 2024

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Oct 6, 2024

@nyalldawson requested a direct download link in a comment once we get Qt6 builds for windows ready. See #57414 (comment)

I didn't want to spam the PR's with more bot comments, so this adds a way to post multiple sections from different workflows into one sticky comment in a reusable way. I hope this will lead to more streamlined and better service comments.

It can be used by adding a step that "schedules" the comment, with a marker (e.g. mingw64) that will delimit the beginning and the end of the corresponding comment section for future replacement.

      - name: Schedule download comment
        uses: ./.github/actions/post_sticky_comment
        with:
          marker: mingw64
          body: |
            ### 🪟 Windows builds
            Download [Windows builds of this PR for testing](${{ steps.artifact-win64.outputs.artifact-url }}).
            Debug symbols for this build are available [here](${{ steps.artifact-win64-debug.outputs.artifact-url }}).";
            *(Built from commit ${{ github.event.pull_request.head.sha }})*
          pr: ${{ github.event.number }}

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 6, 2024
Copy link

github-actions bot commented Oct 6, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit c78be25)

@m-kuhn m-kuhn changed the title Isolate post sticky comment logic Isolate "post sticky comment" logic Oct 6, 2024
@m-kuhn m-kuhn added the Chore GitHub and other CI infrastructure changes label Oct 6, 2024
@m-kuhn m-kuhn merged commit 699c004 into qgis:master Oct 6, 2024
25 checks passed
@m-kuhn m-kuhn deleted the commentify branch October 6, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore GitHub and other CI infrastructure changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants