Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Qt6 builds based on vcpkg #58993

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Windows Qt6 builds based on vcpkg #58993

merged 5 commits into from
Oct 8, 2024

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Oct 7, 2024

Description

Refs qgis/QGIS-Enhancement-Proposals#292
Continues #57414

This adds windows builds with Qt6, based on vcpkg dependencies.

The features WITH_BINDINGS, WITH_3D and WITH_GUI are supported and appropriately enable or disable building the required dependencies. Feature dependencies for server, opencl and quick are prepared but not yet wired.

Python support is consumed from https://github.com/open-vcpkg/python-registry/ . This is currently focused on shipping python dependencies that contain native code (dll's). Other dependencies can be installed using pip.

It is currently based on Qt 6.7.2

This also disables the mingw msys2 build, to reduce the CI infrastructure footprint. The other mingw builds which provide testable qt5 builds are still produced.

TODO:

  • write README INSTALL.md

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 2c89431)

@nicogodet
Copy link
Member

I tried the output build, I had to manually install numpy, urllib3, markupsafe and requests with pip to have a qgis without error at opening on a fresh profile.

I encounter some crashes (I tried to reproduce #53806 and it crashes when trying to set output path at opening expression dialog).

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 8, 2024

Thank you @nicogodet

Regarding the python dependencies, I'm planning to come up with a follow up pull request to take care of these. I'm right now in the process of doing a mass update of python libs here open-vcpkg/python-registry#42

Regarding the crash, I'm not (yet) able to tell where this comes from. Qt6 support is still experimental and I think we'll want to keep these things in new issues which can be treated in the following months while stabilizing Qt6 support.

@nicogodet
Copy link
Member

@m-kuhn crash reported here #59003

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 8, 2024

I'll proceed and merge this and follow up with a pull request to improve the python situation

@m-kuhn m-kuhn merged commit 1aa9a9a into master Oct 8, 2024
29 checks passed
@m-kuhn m-kuhn deleted the winvcpkg branch October 8, 2024 12:44
@MehdiChinoune
Copy link
Contributor

I think cross-building on Fedora/mingw-w64 should be disabled instead of native building on MSYS2/mingw-w64.

@m-kuhn
Copy link
Member Author

m-kuhn commented Oct 11, 2024

@MehdiChinoune no strong opinion on my side. I was just preserving the build that was published as pull request comments. Should we switch this to MSYS2/mingw-w64 (and if yes, what's better about it)?

@tsmcgrath
Copy link

@nicogodet See this comment for getting the freeze repro to run:
#53806 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants