Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elevation profile on virtual point cloud #59073

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

dvdkon
Copy link
Contributor

@dvdkon dvdkon commented Oct 14, 2024

Description

This PR fixes elevation profile generation on virtual point cloud (VPC) layers by changing QgsPointCloudLayerProfileGenerator::generateProfile() to consider sub-indexes.

Will fix #54728

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 4216979)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 4216979)

@nyalldawson nyalldawson reopened this Oct 15, 2024
Copy link
Collaborator

@nyalldawson nyalldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just some minor code consistency comments to bring it inline with conventions used across the QGIS codebase

@dvdkon
Copy link
Contributor Author

dvdkon commented Oct 17, 2024

Looking good! Just some minor code consistency comments to bring it inline with conventions used across the QGIS codebase

Thanks! I've pushed a revised commit.

@nyalldawson nyalldawson added the Squash! Remember to squash this PR, instead of merging or rebasing label Oct 23, 2024
@wonder-sk wonder-sk merged commit de9377a into qgis:master Oct 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Squash! Remember to squash this PR, instead of merging or rebasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elevation profile does not recognise VPC as an input layer
3 participants