Use a scoped proj logger to avoid user data lifetime issues (backport) #59087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 97c5f95)
Previously we incorrectly tried to reset the proj logger by calling proj_log_func with a nullptr function in some exit paths. This leads to crashes, as the nullptr arg makes proj_log_func a no-op, and then later proj tries to log using the now destroyed user data string list. Make all this more robust by switching to a scoped QgsScopedProjCollectingLogger class, which automatically correctly restores the default QGIS proj logger on destruction and ensures there's no object lifetime issues for the log function vs the user data object. Fixes qgis#36125, other crashes seen in the wild (cherry picked from commit 244da7a)
nyalldawson
added
Backport
rouault
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #59080