Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PostgreSQL provider] Add support for BIT and BIT VARYING data types #59146

Merged
merged 1 commit into from
Oct 20, 2024
Merged

[PostgreSQL provider] Add support for BIT and BIT VARYING data types #59146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/providers/postgres/qgspostgresprovider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1235,6 +1235,8 @@ bool QgsPostgresProvider::loadFields()
fieldTypeName == QLatin1String( "ltree" ) ||
fieldTypeName == QLatin1String( "uuid" ) ||
fieldTypeName == QLatin1String( "xml" ) ||
fieldTypeName == QLatin1String( "bit" ) ||
fieldTypeName == QLatin1String( "varbit" ) ||
fieldTypeName.startsWith( QLatin1String( "time" ) ) ||
fieldTypeName.startsWith( QLatin1String( "date" ) ) )
{
Expand Down Expand Up @@ -1323,7 +1325,7 @@ bool QgsPostgresProvider::loadFields()
}
else
{
QgsMessageLog::logMessage( tr( "Field %1 ignored, because of unsupported type %2" ).arg( fieldName, fieldTType ), tr( "PostGIS" ) );
QgsMessageLog::logMessage( tr( "Field %1 ignored, because of unsupported type %2" ).arg( fieldName, fieldTypeName ), tr( "PostGIS" ) );
continue;
}
}
Expand Down
22 changes: 22 additions & 0 deletions tests/src/python/test_provider_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3507,6 +3507,28 @@ def testColumnRestrictedLayerIsEditable(self):
self.assertTrue(vl.isValid(), "qgis_issue_gh_28835 is an invalid layer")
self.assertTrue(vl.startEditing(), "qgis_issue_gh_28835 is not editable by qgis_test_unprivileged_user after restricted-column insert grant")

def testBitAndBitVarying(self):
"""Test issue GH #59129"""

self.execSQLCommand(
'ALTER TABLE IF EXISTS qgis_test."bit_and_bit_varying" DROP CONSTRAINT IF EXISTS pk_bit_and_bit_varying;')
self.execSQLCommand(
'DROP TABLE IF EXISTS qgis_test."bit_and_bit_varying" CASCADE;')
self.execSQLCommand(
'CREATE TABLE qgis_test."bit_and_bit_varying" ( "T_Id" integer NOT NULL, a BIT(3), b BIT VARYING(5) );')
self.execSQLCommand(
"""INSERT INTO qgis_test."bit_and_bit_varying" VALUES (1, B'101', B'00');""")
self.execSQLCommand(
'ALTER TABLE qgis_test."bit_and_bit_varying" ADD CONSTRAINT pk_gh_bit_and_bit_varying PRIMARY KEY ("T_Id");')

vl = QgsVectorLayer(self.dbconn + ' sslmode=disable key=\'id\' table="qgis_test"."bit_and_bit_varying" () sql=', 'bit_and_bit_varying', 'postgres')
self.assertTrue(vl.isValid())

feat = next(vl.getFeatures())
self.assertTrue(feat.isValid())
self.assertEqual(feat["a"], "101")
self.assertEqual(feat["b"], "00")


class TestPyQgsPostgresProviderCompoundKey(QgisTestCase, ProviderTestCase):

Expand Down
Loading