Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout export quality jpg #59171

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Layout export quality jpg #59171

merged 4 commits into from
Oct 25, 2024
+170 −47

Conversation

YoannQDQ
Copy link
Contributor

@YoannQDQ YoannQDQ commented Oct 22, 2024 •
edited
Loading

Description

Add a quality parameter in QgsLayoutExporter::ImageExportSettings.

For jpeg and jpg, the layout image export dialog now displays an additional line (hidden for other extensions)

image_quality

@github-actions github-actions bot added this to the 3.40.0 milestone Oct 22, 2024
@YoannQDQ
Copy link
Contributor Author

Not sure how to handle the spell check fail, as exportLayersAsSeperateFiles is part of the public API (and I didn't modify it in this PR)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 807b15d)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 807b15d)

@YoannQDQ YoannQDQ added Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks Frozen Feature freeze - Do not merge! labels Oct 22, 2024
nyalldawson
nyalldawson approved these changes Oct 25, 2024
View reviewed changes
src/app/layout/qgslayoutdesignerdialog.h Outdated Show resolved Hide resolved
src/app/layout/qgslayoutdesignerdialog.h Outdated Show resolved Hide resolved
src/gui/layout/qgslayoutimageexportoptionsdialog.cpp Outdated Show resolved Hide resolved
src/gui/layout/qgslayoutimageexportoptionsdialog.cpp Outdated Show resolved Hide resolved
@nyalldawson nyalldawson added Squash! Remember to squash this PR, instead of merging or rebasing and removed Frozen Feature freeze - Do not merge! labels Oct 25, 2024
@nyalldawson nyalldawson merged commit e8e55cd into qgis:master Oct 25, 2024
32 of 33 checks passed
@YoannQDQ YoannQDQ deleted the layout-export-quality-jpg branch October 26, 2024 07:57
@YoannQDQ YoannQDQ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Oct 26, 2024
@qgis-bot
Copy link
Collaborator

@YoannQDQ
A documentation ticket has been opened at qgis/QGIS-Documentation#9319
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@qgis-bot
Copy link
Collaborator

@YoannQDQ
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot qgis-bot mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault left review comments

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks Squash! Remember to squash this PR, instead of merging or rebasing
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.

jpg quality slider in Composer
4 participants
@YoannQDQ @qgis-bot @rouault @nyalldawson