Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not restore connection if URL is empty #59216

Merged
merged 1 commit into from
Oct 25, 2024
Merged

do not restore connection if URL is empty #59216

merged 1 commit into from
Oct 25, 2024

Conversation

3nids
Copy link
Member

@3nids 3nids commented Oct 25, 2024

We might have some dangling referer settings which are never deleted because they are now part of the http-headers.

As safety, we do not restore connections which have empty URLs.

fixes #53321

We might have some dangling referer settings which are never deleted because they are now part of the http-headers.

As safety, we do not restore connections which have empty URLs.

fixes #53321
@github-actions github-actions bot added this to the 3.42.0 milestone Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit e4fff60)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit e4fff60)

@nyalldawson nyalldawson merged commit ef68425 into master Oct 25, 2024
35 checks passed
@nyalldawson nyalldawson deleted the fix53321 branch October 25, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove connection does not delete the connection
2 participants