Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mps for quimb #20

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Mps for quimb #20

merged 6 commits into from
Nov 17, 2023

Conversation

nitinshivaraman
Copy link
Contributor

Added the MPS circuit execution for the quimb library.

@nitinshivaraman nitinshivaraman linked an issue Oct 5, 2023 that may be closed by this pull request
Copy link
Contributor

@Vinitha-balachandran Vinitha-balachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went through the changes, codes seems fine and tested in local machine

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments. The only relevant one is that about the is_mps propagation.

Btw, mps is also enough for the name of the option.

src/qibotn/quimb.py Show resolved Hide resolved
src/qibotn/quimb.py Outdated Show resolved Hide resolved
src/qibotn/quimb.py Outdated Show resolved Hide resolved
@nitinshivaraman nitinshivaraman merged commit 918958a into main Nov 17, 2023
@alecandido alecandido deleted the mps-for-quimb branch March 1, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MPS support for Quimb
4 participants