-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exception test #136
add exception test #136
Conversation
Code Coverage Report
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 54.76% 55.57% +0.80%
==========================================
Files 164 163 -1
Lines 7945 7939 -6
==========================================
+ Hits 4351 4412 +61
+ Misses 3594 3527 -67 ☔ View full report in Codecov by Sentry. |
Code Coverage Report
|
Code Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#119
Through the
lcov
tool, I observed that functions such asrouter::get_name_by_key
andrest_rpc::get_error_msg
were not covered by tests. These functions will be triggered when exceptions occur, so I added some exception tests.