Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow filtering on multiple semantic types #144

Open
jwdebelius opened this issue Oct 5, 2021 · 3 comments
Open

Allow filtering on multiple semantic types #144

jwdebelius opened this issue Oct 5, 2021 · 3 comments

Comments

@jwdebelius
Copy link

Current Behavior
Currently, q2-taxa only allows you to operate on a Frequency feature table semantic type, and you can only perform taxonomic filtering on Sequences.

Proposed Behavior
I'd like to be able to collapse relative frequency and compositional tables. (I think it would be harder to manage with presence/absence), filter relative frequency and presence/absent tables, and filter aligned sequences.

@gregcaporaso
Copy link
Member

gregcaporaso commented Sep 6, 2023

In the comment on this issue, collapse is mentioned, and there is a discussion of that under #104. Let's focus this issue on the filter-table action, which should accept other FeatureTable types as input. PresenceAbsence is one that I need right now, and is an easy one (because all values remain independent). RelativeFrequency (and I think Composition) are harder, because the values in the table would need to be recomputed after features are removed.

To achieve this, we'll need to allow FeatureTable[PresenceAbsence] as an input, and add a TypeMap such that the output FeatureTable subtype matches the input FeatureTable subtype.

@cherman2
Copy link

cherman2 commented May 22, 2024

@hagenjp Just did something like this for q2-taxa so she is going to take a stab at this issue!

Seems like we had two github issues for this on our release board.

@hagenjp
Copy link
Contributor

hagenjp commented May 23, 2024

  • introduce ability to collapse relative frequency
  • introduce ability to collapse compositional tables
  • Add ability to filter relative frequency
  • Add ability to filter aligned seqs
  • allow FeatureTable[PresenceAbsence] as an input to filter, and add a TypeMatch such that the output FeatureTable subtype matches the input FeatureTable subtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants