Destroyed ships will not be revived when bombed #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relsmoler
force-pushed
the
bugfix/battleships-engine-destroyed-ships
branch
from
f2c5283
to
016e876
Compare
relsmoler
force-pushed
the
bugfix/battleships-engine-destroyed-ships
branch
from
016e876
to
f0826dd
Compare
relsmoler
changed the title
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed bug: ships that were already destroyed will not be "revived" when bombed.
Details and comments
Implementation: updated the bomb array to mark destroyed ships. The relevant quantum operation then takes the ships state and number of bombs into consideration to calculate the ships current status.
If "reviving" already destroyed ships back to life when bombed was planned as a feature - feel free to ignore this suggested fix and close this PR.