Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tutorial for designs.MultiPlanar and square vertical CPW #931

Closed
wants to merge 11 commits into from

Conversation

clarkmiyamoto
Copy link
Contributor

What are the issues this pull addresses (issue numbers / links)?

#930

Did you add tests to cover your changes (yes/no)?

No-- it's a tutorial

Did you update the documentation accordingly (yes/no)?

Yes

Did you read the CONTRIBUTING document (yes/no)?

Yes

Summary

  • Added tutorial explaining how to make multi layer designs
  • Added new component to QLibrary called SPole (square vertical CPW)

Details and comments

@priti-ashvin-shah-ibm
Copy link
Collaborator

Hi Clark,
https://github.com/Qiskit/qiskit-metal/pull/864/files
This link show when another person added new components to repository. Can you take a look. There are images that are also added. So, when user used the Metal GUI, a small icon with image can be viewed.

@priti-ashvin-shah-ibm
Copy link
Collaborator

Also, the init file is updated along with adding a test cases. The previous merged pull request may be helpful as an example.

@zlatko-minev zlatko-minev self-requested a review May 22, 2023 00:54
@clarkmiyamoto clarkmiyamoto marked this pull request as draft May 31, 2023 21:57
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@zlatko-minev zlatko-minev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants