Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOLOE-515 - refactor: Cleaner dev structure #6

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

SenChung
Copy link
Contributor

@SenChung SenChung commented Sep 11, 2024

This is an update to the Breadcrumbs DXP.

Moved the JSON data to previews folder.
Fixed the main.cjs to map to breadcrumbs object.

@SenChung SenChung requested review from duttonw and elvishu September 11, 2024 05:18
@duttonw
Copy link
Member

duttonw commented Sep 11, 2024

Can you move this to the src/layout folder for your breadcrumb component.

duttonw
duttonw previously approved these changes Sep 11, 2024
"brandOverride": "alt",
"breadcrumbs": [
{
"link": "#",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update to have the real data that's on forgov for a more lifelike example.

@duttonw duttonw changed the title Cleaner dev structure QOLOE-515 - refactor: Cleaner dev structure Sep 11, 2024
- Split templates from layout
- Create sample template element 'globalAlert'
@duttonw duttonw merged commit 9d2eb7e into main Sep 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants