init Back to top #585
Open
init Back to top #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvishu
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Hi @SenChung,
This component is not showing on the PR's Storybook.
https://660e3e06af8da379e06be302-zrpzxabqbq.chromatic.com/?path=/story/3-components-backtotop--default
duttonw
reviewed
Jan 15, 2025
| <a href="#" id="backToTop" class="qld__btn qld__btn--floating qld__btn--back-to-top" aria-label="Back to top"> | ||
| <span>Back to top</span> | ||
| <div class="qld__widgets {{#if dynamic}}fixed{{/if}}"> | ||
| <a href="#" id="backToTop" class="qld__btn qld__btn--floating qld__btn--back-to-top show" data-offset="{{offset}}" data-dynamic="{{dynamic}}" aria-label="{{text}}"> |
There was a problem hiding this comment.
should have 'default' if 'text' is not set, i.e. 'Back to top'
offset default should be '100'.
Also why is dynamic when true == fix.
and data-dynamic default if not set is 'false'
There was a problem hiding this comment.
These issues are now fixed with the latest push
reverted: package-lock.json to the develop version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Init Back To Top setup.
This is very much based on the work the Steve has done within The Vanilla Project.
There are a few small differences with the id of backToTop and CSS/SCSS names + the JS.