-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs do not seem to show methods implemented in QuantumOpticsBase #373
Comments
We should probably create a "Full API" page in addition to the curated API page (https://github.com/qojulia/QuantumOptics.jl-documentation/blob/master/src/api.md) that just list everything |
@Krastanov I think we should just complete the existing API (I briefly talked to @david-pl). I can do this at some point. |
I agree, it would be great to extend the curated list. The suggestion for a hidden "Full API" page is more so that future omissions like this (which will inevitably happen) do not cause even the search function to fail. Some combination of multidocumenter and strict warnings during build can also help. |
I included now all the missing APIs in the docu. When you build the documentation you get a warning for all the missing APIs. |
What I am suggesting is turning that warning into an error, so it gets detected during pull requests. Like here: https://github.com/QuantumSavory/QuantumClifford.jl/blob/master/docs/make.jl#L24 One just needs to be careful: there is a particular warning type that shows up when an unexported method with a docstring is NOT in the public documentation. But unexported methods are usually private and can break at any time, so it is correct to not have them in the documentation. The |
I guess this would be beneficial. However, when I build the docu I always obtain the following strange warning which would turn into an error: |
Not certain, but presumably the docstring for |
the doc issues have been fixed |
Compare https://docs.qojulia.org/search/?q=squeeze and https://qojulia.github.io/QuantumOpticsBase.jl/latest/search/?q=squeeze
Noticed by @karolpezet at #372
The text was updated successfully, but these errors were encountered: