fix #1226

qossmic · Jun 20, 2023 · 0d2fd75 · 0d2fd75
1 parent fd635ed
commit 0d2fd75
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/Contract/Analyser/EventHelper.php b/src/Contract/Analyser/EventHelper.php
@@ -33,15 +33,16 @@ public function __construct(
      */
     public function shouldViolationBeSkipped(string $depender, string $dependent): bool
     {
-        if (!array_key_exists($depender, $this->skippedViolations)) {
-            return false;
-        }
-        $key = array_search($dependent, $this->unmatchedSkippedViolation[$depender], true);
-        if (false === $key) {
+        $skippedViolation = $this->skippedViolations[$depender] ?? [];
+        $matched = [] !== $skippedViolation && in_array($dependent, $skippedViolation, true);
+
+        if (!$matched) {
             return false;
         }
 
-        unset($this->unmatchedSkippedViolation[$depender][$key]);
+        if (false !== ($key = array_search($dependent, $this->unmatchedSkippedViolation[$depender], true))) {
+            unset($this->unmatchedSkippedViolation[$depender][$key]);
+        }
 
         return true;
     }