Skip to content

Commit

Permalink
Fix released package for Chrome (#41)
Browse files Browse the repository at this point in the history
  • Loading branch information
pbek committed Dec 21, 2022
1 parent baf8fab commit 6a363a0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/build-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: ${{ steps.create_release.outputs.upload_url }}
asset_path: packages/qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
# asset_path: packages/qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
asset_path: packages/chrome.zip
asset_name: qownnotes-web-companion.v20${{ env.VERSION }}.chrome.zip
asset_content_type: application/zip
- name: Upload Firefox package
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# QOwnNotes Web Companion Changelog

## 22.12.1
- the package for Chrome was fixed (for [#41](https://github.com/qownnotes/web-companion/issues/41))

## 22.12.0
- changed Firefox default shortcut to <kbd>Ctrl + Alt + B</kbd> since the browser blocked <kbd>Ctrl + Shift + B</kbd>
(for [#48](https://github.com/qownnotes/web-companion/issues/48))
Expand Down
6 changes: 4 additions & 2 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ cd "$DIR" || exit 1
sed -i -e 's/"version": "/"version": "20/g' package.json || exit 1
npm run build chrome || exit 1

# this is done by replace-in-file-webpack-plugin now
## remove background.scripts from manifest.json for manifest v3 for Chrome
#jq 'del(.background.scripts)' dist/chrome/manifest.json > /tmp/manifest.json && mv /tmp/manifest.json dist/chrome/manifest.json
## create new package
#pushd dist/chrome && zip -r ../../packages/chrome.zip . && popd

# create new package for Chrome (still needs to be done, because the changes replace-in-file-webpack-plugin does are not present in the generated package)
pushd dist/chrome && zip -r ../../packages/chrome.zip . && popd || exit 1

# switch back to the correct version number format again
sed -i -e 's/"version": "20/"version": "/g' package.json || exit 1
Expand Down

0 comments on commit 6a363a0

Please sign in to comment.