Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github merge_group is missing #664

Open
janpk opened this issue Sep 4, 2024 · 5 comments
Open

Github merge_group is missing #664

janpk opened this issue Sep 4, 2024 · 5 comments

Comments

@janpk
Copy link

janpk commented Sep 4, 2024

Hi, would it be possible to get support for the merge_group event to avoid using @RawEvent?

@gsmet
Copy link
Member

gsmet commented Sep 4, 2024

Hey!

It would need to be added here first: https://github.com/hub4j/github-api/blob/main/src/main/java/org/kohsuke/github/GHEventPayload.java .

I'm pretty full at the moment so if you have time you could experiment with it?

If not, I'll put in on my list but probably won't get to it before mid-October.

@janpk
Copy link
Author

janpk commented Sep 4, 2024

I will take a look at hub4j and try to figure out what needs to be done there. Just need to rewire my brain from Kotlin to Java😄

Closing this issue for now. Will create a new one depending on what I'm able to do with hub4j

@janpk janpk closed this as completed Sep 4, 2024
@gsmet gsmet reopened this Sep 4, 2024
@gsmet
Copy link
Member

gsmet commented Sep 4, 2024

We can keep it open. Let me know how it goes for you and I’ll keep on my TODO if you don’t beat me to it.

@gsmet
Copy link
Member

gsmet commented Sep 4, 2024

That being said, if you can get me an example payload, I might be able to check if it’s a matter of a few minutes or more.

@janpk
Copy link
Author

janpk commented Sep 5, 2024

Here is the merge_group: checks requested

{
    "action": "checks_requested",
    "merge_group": {
        "head_sha": "9372b57f677a2562db635fff72c74ced03af444c",
        "head_ref": "refs/heads/gh-readonly-queue/main/pr-29-db6125c8fc1e4021c0126b9e76d77bbb3849f3cc",
        "base_sha": "db6125c8fc1e4021c0126b9e76d77bbb3849f3cc",
        "base_ref": "refs/heads/main",
        "head_commit": {
            "id": "9372b57f677a2562db635fff72c74ced03af444c",
            "tree_id": "93c270f96343b61ca2c690befba30a71818f5d27",
            "message": "Merge pull request #29 from myorganization/feature/app-test-3\n\nchore: Updated PR template",
            "timestamp": "2024-09-05T11:54:00Z",
            "author": {
                "name": "Jan-Petter Krüger",
                "email": "j.p.k@myorg.com"
            },
            "committer": {
                "name": "GitHub",
                "email": "noreply@github.com"
            }
        }
    },
    "repository": {
    },
    "organization": {
    },
    "enterprise": {
    },
    "sender": {
    },
    "installation": {
    }
}

and merge_group: destroyed

{
    "action": "destroyed",
    "merge_group": {
        "head_sha": "db6125c8fc1e4021c0126b9e76d77bbb3849f3cc",
        "head_ref": "refs/heads/gh-readonly-queue/main/pr-28-84f9a3b9f76337ee77ed1511cedaa8694bbd5aa0",
        "base_sha": "84f9a3b9f76337ee77ed1511cedaa8694bbd5aa0",
        "base_ref": "refs/heads/main",
        "head_commit": {
            "id": "db6125c8fc1e4021c0126b9e76d77bbb3849f3cc",
            "tree_id": "5f19bd2b0c152924a44b4a0c475a4a1b50e3855c",
            "message": "Merge pull request #28 from myorganization/feature/app-test-2\n\nchore(docs): contributed to readme",
            "timestamp": "2024-09-05T11:27:04Z",
            "author": {
                "name": "Jan-Petter Krüger",
                "email": "j.p.k@myorg.com"
            },
            "committer": {
                "name": "GitHub",
                "email": "noreply@github.com"
            }
        }
    },
    "reason": "merged",
    "repository": {
    },
    "organization": {
    },
    "enterprise": {
    },
    "sender": {
    },
    "installation": {
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants