Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sketch out API for auditing #83

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Sketch out API for auditing #83

merged 2 commits into from
Dec 6, 2023

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Dec 4, 2023

No description provided.

@geoand geoand mentioned this pull request Dec 4, 2023
@geoand geoand force-pushed the audit branch 4 times, most recently from a3c3c0d to a61cc5d Compare December 4, 2023 13:57
@geoand
Copy link
Collaborator Author

geoand commented Dec 4, 2023

@cescoffier WDYT? It's very bare bones ATM, but I think it's fine for a first version

Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what I had in mind.

@geoand
Copy link
Collaborator Author

geoand commented Dec 4, 2023

I still need to add some documentation entry

@geoand geoand marked this pull request as ready for review December 5, 2023 07:34
@geoand geoand requested a review from a team as a code owner December 5, 2023 07:34
@geoand
Copy link
Collaborator Author

geoand commented Dec 5, 2023

@jmartisk the pinecone test is failing, do you have any idea?

@jmartisk
Copy link
Collaborator

jmartisk commented Dec 5, 2023

Hard to say, maybe some other CI was running in parallel with it?
That test is really hard to maintain because of the shared database :( and because we need that delay after removing items, we currently have 30 seconds, but I'm not sure it's always enough

@jmartisk
Copy link
Collaborator

jmartisk commented Dec 5, 2023

I'll try to run the tests for this PR on my laptop

@geoand
Copy link
Collaborator Author

geoand commented Dec 5, 2023

One thing I am thinking we should do is introduce the Git Incremental Builder by @famod that we also use in Quarkus, as it an awesome way of only running tests for modules that can be affected by a change

@jmartisk
Copy link
Collaborator

jmartisk commented Dec 5, 2023

I see you re-ran the tests and the Pinecone tests passed this time, but there's some other failures this time.... lovely

@geoand
Copy link
Collaborator Author

geoand commented Dec 5, 2023

On this current run it seems like pinecode failed again

@geoand
Copy link
Collaborator Author

geoand commented Dec 5, 2023

There is something very weird going on with the native tests that requires more investigation

@famod
Copy link

famod commented Dec 5, 2023

@geoand

One thing I am thinking we should do is introduce the Git Incremental Builder by @famod that we also use in Quarkus, as it an awesome way of only running tests for modules that can be affected by a change

Happy to help! I should have some time for that later this month. Best create an issue with some details and assign it to me. 🙂

@geoand
Copy link
Collaborator Author

geoand commented Dec 5, 2023

Will do, thanks!

@geoand geoand force-pushed the audit branch 5 times, most recently from 78fbbf5 to 16d9da4 Compare December 6, 2023 07:46
@geoand geoand merged commit 574e0e1 into main Dec 6, 2023
1 of 2 checks passed
@geoand geoand deleted the audit branch December 6, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants