Ignore known annotations in parameter binding #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Dec 4, 2023
gsmet
reviewed
Dec 4, 2023
| if (name.startsWith("kotlin")) { | ||
| return false; | ||
| } | ||
| if (name.endsWith("NotNull")) { |
There was a problem hiding this comment.
I wonder if you should ignore everything under jakarta.validation.constraints. instead.
There was a problem hiding this comment.
Sure, I'll add that as well
There was a problem hiding this comment.
NotNull are super common - most tools even allow custom ones, so I'll leave the rule here
There was a problem hiding this comment.
I was wondering if we shouldn't add CheckReturnValue.
There was a problem hiding this comment.
That is only for return values, no?
There was a problem hiding this comment.
Jakarta Validation also has @NotBlank which could be useful in this case. Thus my recommendation.
You can keep not null as is but I would also ignore everything under jakarta.validation.constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #88