Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "OpenOffice" with "OpenDocument" #1336

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

stragu
Copy link
Contributor

@stragu stragu commented Sep 17, 2024

ODF (and its subset ODT) is not tied to one software project. And in any case, Apache OpenOffice is rather on life support, whereas most contributions to the OpenOffice.org descendants are currently going to LibreOffice.
MS Office also opens ODF and recently announced support for version 1.4.

ODF is not tied to one software project. And in any case, Apache OpenOffice is rather on life support, whereas most contributions to the OpenOffice.org descendants are currently going to LibreOffice.
MS Office also opens ODF and recently announced support for version 1.4.
@stragu
Copy link
Contributor Author

stragu commented Sep 17, 2024

I wasn't sure how to squash on the GitHub website, I assume it can be done on your side?

@cderv
Copy link
Collaborator

cderv commented Sep 17, 2024

Hi !

Thanks for the suggestion.

I believe we inherit this wording from Pandoc itself. Pandoc differentiate between

  • --to opendocument
  • --to odt

And they mention OpenOffice Text Document in their links are https://pandoc.org/MANUAL.html#option--to

I am not sure what OpenDocument for Pandoc really targets as the links from their docs point to nowhere:
https://opendocument.xml.org/ and odt points to https://en.wikipedia.org/wiki/OpenDocument

I believe --to opendocument is to write the XML "flat" (.fodt extension) while --to odt the file format .odt.

Both exist and maybe we should use those terms odt and flat odt

Anyhow, I agree with the change here.

@cscheid @cwickham what do you think about this ?

@cscheid
Copy link
Collaborator

cscheid commented Sep 17, 2024

We should keep the existing documentation. It's not perfectly accurate, but its inconsistencies are minor and follow Pandoc. That's better than the alternative. Notice, also, that we say "MS Word" even though other programs produce/consume .docx.

@cscheid cscheid closed this Sep 17, 2024
@stragu
Copy link
Contributor Author

stragu commented Jan 10, 2025

Thanks for the comments.

It's not perfectly accurate, but its inconsistencies are minor and follow Pandoc.

What do you mean by "follow Pandoc"?

  • The Pandoc manual only uses "OpenOffice" 2 times, in the string "OpenOffice text document", for linking to the Wikipedia page titled "OpenDocument". In the same manual, the terms "odt" and "opendocument" are the CLI options, as @cderv mentioned, and the terms are used 49 and 13 times respectively.
  • The main Pandoc page lists it as "OpenOffice/LibreOffice ODT" and links again to the OpenDocument wikipedia page.

So I'd argue we're not actually following Pandoc, and we should rather be precise and use the CLI name "ODT" (given that that's the output format we use in Quarto, rather than the plain text the opendocument output format creates - see the related issue I opened at Pandoc, to clarify the distinction between the two).

I agree it's a minor change, but I still think it's a disservice to users to (1) point to a single piece of software when the format is tool-agnostic and (2) to point to a piece of software that is on life support (hasn't had a bugfix release for more than a year).

@stragu
Copy link
Contributor Author

stragu commented Jan 13, 2025

Update: jgm has updated the pandoc documentation, so the manual does not contain any mention of OpenOffice anymore.

@cscheid cscheid reopened this Jan 13, 2025
@cscheid
Copy link
Collaborator

cscheid commented Jan 13, 2025

Now it makes sense for us to follow, thanks.

@cscheid cscheid merged commit 14e67c0 into quarto-dev:main Jan 13, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
* replace "OpenOffice" with "OpenDocument"

ODF is not tied to one software project. And in any case, Apache OpenOffice is rather on life support, whereas most contributions to the OpenOffice.org descendants are currently going to LibreOffice.
MS Office also opens ODF and recently announced support for version 1.4.

* replace "OpenOffice" with "OpenDocument"

(cherry picked from commit 14e67c0)
Copy link
Contributor

Successfully created backport PR for prerelease:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants