feat(lua): When possible, use Quarto Lua API from Quarto 1.5.32+ to get the path to quarto #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Quarto CLI executable. Otherwise, this extension fails to call `quarto run` on environment where `quarto` is not in the PATH. Though, even if in the PATH, it could be calling another quarto CLI that the one used to run the extension
schloerke
changed the title
schloerke
approved these changes
May 14, 2024
schloerke
changed the title
|
Tagged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, this extension fails to call
quarto runon environment wherequartois not in the PATH. Though, even if in the PATH, it could be calling another quarto CLI that the one used to run the extensioncloses #50
@schloerke
this is a companion to
quarto.cli_pathin our Quarto LUA API quarto-dev/quarto-cli#9576and should be merged only after, and when Quarto 1.5 will be out. Hence the draft PR.
There is also a way to have another fix for #50 by directly handling this specific CLI path resolution so that it works also with older versions