Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update supported Go versions to Go 1.21 and 1.22 #41

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

marten-seemann
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (0363c49) to head (4702a42).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   90.82%   91.42%   +0.60%     
==========================================
  Files           5        5              
  Lines         207      233      +26     
==========================================
+ Hits          188      213      +25     
- Misses         10       11       +1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit cc06259 into master Apr 2, 2024
11 checks passed
@jakubgs
Copy link

jakubgs commented Apr 15, 2024

Thanks for fixing this. Any plans to create a release that includes this?

@marten-seemann
Copy link
Member Author

No, there's no need for a new release.

@siddarthkay
Copy link

@marten-seemann : When I upgrade status-go to 1.21 I get this error :

/Users/siddarthkumar/gopath/src/github.com/status-im/status-go/vendor/github.com/quic-go
/quic-go/internal/qtls/go121.go:5:13: cannot use "The version of quic-go you're using can't be built 
on Go 1.21 yet. For more details, please see 
https://github.com/quic-go/quic-go/wiki/quic-go-and-Go-versions." 
(untyped string constant "The version of quic-go you're using can't be built on Go 1.21 yet. F...) 
as int value in variable declaration

I could still use master, but would be nice if you'd release it as well.

Thank you :)

@marten-seemann
Copy link
Member Author

This is not a qpack error.

@siddarthkay
Copy link

Yes sorry my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants