Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vllm install and test added. #160

Closed
wants to merge 5 commits into from
Closed

Conversation

quic-amitraj
Copy link
Contributor

@quic-amitraj quic-amitraj commented Oct 22, 2024

  1. This VLLM testing directory provides installation and testing of VLLLM to be incorporated in the efficient-transformers CI.
  2. A basic sanity check for VLLM is provided that
    a) installs the latest VLLM
    b) downloads and compiles a small model (efficient-transformers)
    c) checks for three sanity checks to see if the model runs correctly on VLLM and passes initial tests.

@quic-amitraj
Copy link
Contributor Author

@quic-mahebala Please use ruff lint and format and push again.

@quic-amitraj quic-amitraj marked this pull request as draft October 23, 2024 04:24
@quic-mahebala
Copy link

  1. This VLLM testing directory provides installation and testing of VLLLM to be incorporated in the efficient-transformers CI.
  2. A basic sanity check for VLLM is provided that
    a) installs the latest VLLM
    b) downloads and compiles a small model (efficient-transformers)
    c) checks for three sanity checks to see if the model runs correctly on VLLM and passes initial tests.

tests/vllm/conftest.py Outdated Show resolved Hide resolved
tests/vllm/install_test_vllm.sh Outdated Show resolved Hide resolved
scripts/Jenkinsfile Outdated Show resolved Hide resolved
scripts/Jenkinsfile Show resolved Hide resolved
scripts/Jenkinsfile Show resolved Hide resolved
tests/vllm/test_qaic_output_consistency.py Outdated Show resolved Hide resolved
tests/vllm/test_qaic_output_consistency.py Outdated Show resolved Hide resolved
sh '''
. preflight_qeff/bin/activate
pytest --disable-warnings -s -v tests/vllm --junitxml=tests/tests_log3.xml
junitparser merge tests/tests_log1.xml tests/tests_log2.xml tests/tests_log.xml tests/tests_log3.xml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase, the jenkinsfile already had some change after PR #116 merge.
Also you need to do junitparser merge split_1.xml split_2.xml split_3.xml split_4.xml tests/tests_log.xml

tests_log.xml should be the output file and at the end of the command, as this will be used by junit to display test results at the end of the pipeline in Post

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: Mahesh Balasubramanian <quic_mahebala@quicinc.com>
Signed-off-by: Mahesh Balasubramanian <quic_mahebala@quicinc.com>
Signed-off-by: Mahesh Balasubramanian <quic_mahebala@quicinc.com>
Signed-off-by: Mahesh Balasubramanian <quic_mahebala@quicinc.com>
Signed-off-by: Mahesh Balasubramanian <quic_mahebala@quicinc.com>
@ochougul
Copy link
Contributor

ochougul commented Nov 7, 2024

Being addressed at #168

@ochougul ochougul closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants