From cb67c3976dcfe4a0fd55bac0c91f19cc5414b5de Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 15 Sep 2023 20:29:49 -0700 Subject: [PATCH] Test: update grunt-contrib-qunit integration to 8.0.1 Ref https://github.com/gruntjs/grunt-contrib-qunit/pull/204. --- test/integration/grunt-contrib-qunit.js | 11 ++++++----- test/integration/grunt-contrib-qunit/package.json | 4 ++-- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/test/integration/grunt-contrib-qunit.js b/test/integration/grunt-contrib-qunit.js index 431db2755..d669db16b 100644 --- a/test/integration/grunt-contrib-qunit.js +++ b/test/integration/grunt-contrib-qunit.js @@ -28,9 +28,10 @@ QUnit.test.each('failing tests', { >> Expected: undefined >> Error: No tests were run. >> at `], - uncaught: ['fail-uncaught', `Testing fail-uncaught.html ->> Error: ReferenceError: boom is not defined ->> at file:fail-uncaught.html:16`] + // FIXME: Error line is off by one in Chrome, broke betweeen Puppeteer 9 and 21. + uncaught: ['fail-uncaught', `Testing fail-uncaught.html \n\ +>> ReferenceError: boom is not defined +>> at file:fail-uncaught.html:15`] }, (assert, [command, expected]) => { try { const ret = cp.execSync('node_modules/.bin/grunt qunit:' + command, { @@ -45,8 +46,8 @@ QUnit.test.each('failing tests', { }); assert.equal(ret, null); } catch (e) { - const actual = e.stdout.replace(/at .*[/\\]([^/\\]+\.html)(:\d+)?(:\d+)?/gm, 'at file:$1$2'); - assert.pushResult({ result: actual.includes(expected), actual, expected }); + const actual = e.stdout.replace(/at .*[/\\]([^/\\]+\.html)(:\d+)?.*$/gm, 'at file:$1$2'); + assert.pushResult({ result: actual.includes(expected), actual, expected }, 'stdout'); assert.true(e.status > 0, 'non-zero exit code'); } }); diff --git a/test/integration/grunt-contrib-qunit/package.json b/test/integration/grunt-contrib-qunit/package.json index 2375a81b2..30089f1a7 100644 --- a/test/integration/grunt-contrib-qunit/package.json +++ b/test/integration/grunt-contrib-qunit/package.json @@ -1,8 +1,8 @@ { "private": true, "devDependencies": { - "grunt": "^1.5.1", - "grunt-contrib-qunit": "^6.2.0" + "grunt": "^1.6.1", + "grunt-contrib-qunit": "^8.0.1" }, "scripts": { "test": "grunt"