Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Refactor internal ProcessingQueue into class #1740

Merged
merged 1 commit into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. Core: Refactor internal ProcessingQueue into class

    This is motivated by the last remaining build warning from Rollup:
    
    > src/qunit.js → qunit/qunit.js...
    > (!) Circular dependency
    > src/test.js -> src/core/processing-queue.js -> src/test.js
    > created qunit/qunit.js in 2s
    
    ProcessingQueue needs access to the `test` function defined in test.js.
    
    Fix by turning the module into a class, that we create a singleton
    of in core.js (with access to test.js) and then use that singleton
    where we previously used ProcessingQueue statically.
    Krinkle committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    dfbe91a View commit details
    Browse the repository at this point in the history