Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use periodic BC for PopIII #739

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Sep 8, 2024

Description

Use periodic hydro boundary conditions in order to avoid numerical problems with outflow boundary conditions. Gravity is still computed using open boundary conditions.

This current fails at runtime due to an assertion in the Poisson solver:

Assertion `m_lobc[icomp][idim] == BCType::Periodic && m_hibc[icomp][idim] == BCType::Periodic' failed, file "/home1/02661/bwibking/quokka/extern/amrex/Src/LinearSolvers/MLMG/AMReX_MLLinOp.H", line 1199 !!!

Related issues

Closes #732.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

Copy link

sonarqubecloud bot commented Sep 8, 2024

@BenWibking
Copy link
Collaborator Author

We can create a new amrex::Geometry object just for the Poisson solve that is non-periodic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PopIII sim needs diode boundary condition
1 participant