Fix failing to send attachments due to already open file

quotient-im · Feb 1, 2024 · 700dd4d · 700dd4d
1 parent d0c07c5
commit 700dd4d
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/client/chatroomwidget.cpp b/client/chatroomwidget.cpp
@@ -341,7 +341,8 @@ void ChatRoomWidget::dropFile(const QString& localPath)
 QString ChatRoomWidget::checkAttachment()
 {
     Q_ASSERT(m_fileToAttach != nullptr);
-    if (m_fileToAttach->open(QIODevice::ReadOnly))
+    if (m_fileToAttach->isReadable()
+        || m_fileToAttach->open(QIODevice::ReadOnly))
         return {};
 
     // Form the message in advance while the file name is still there
@@ -415,10 +416,6 @@ QString ChatRoomWidget::sendFile()
     if (const auto error = checkAttachment(); !error.isEmpty())
         return error;
 
-    if (!m_fileToAttach->open(QIODevice::ReadOnly))
-        return tr("%1 is not readable or not a file")
-            .arg(m_fileToAttach->fileName());
-
     QFileInfo fileInfo(*m_fileToAttach);
     currentRoom()->postFile(description.isEmpty() ? fileInfo.fileName()
                                                   : description,