BaseJob: use string views where appropriate

Basically replicating QJson* API capabilities for specific calls.

Quotient/jobs/basejob.cpp

@@ -567,7 +567,17 @@ BaseJob::Status BaseJob::prepareError(Status currentStatus)
     return currentStatus; // The error payload is not recognised
 }
 
-QJsonValue BaseJob::takeValueFromJson(const QString& key)
+QJsonValue BaseJob::takeValueFromJson(QStringView key)
+{
+    if (!d->jsonResponse.isObject())
+        return QJsonValue::Undefined;
+    auto o = d->jsonResponse.object();
+    auto v = o.take(key);
+    d->jsonResponse.setObject(o);
+    return v;
+}
+
+QJsonValue BaseJob::takeValueFromJson(QLatin1StringView key)
 {
     if (!d->jsonResponse.isObject())
         return QJsonValue::Undefined;

Quotient/jobs/basejob.h

@@ -173,20 +173,19 @@ class QUOTIENT_API BaseJob : public QObject {
     //!
     //! If there's no top-level JSON object in the response or if there's
     //! no node with the key \p keyName, \p defaultValue is returned.
-    template <typename T, typename StrT>
-    T loadFromJson(const StrT& keyName, T&& defaultValue = {}) const
+    template <typename T>
+    T loadFromJson(auto keyName, T&& defaultValue = {}) const
     {
         const auto& jv = jsonData().value(keyName);
-        return jv.isUndefined() ? std::forward<T>(defaultValue)
-                                : fromJson<T>(jv);
+        return jv.isUndefined() ? std::forward<T>(defaultValue) : fromJson<T>(jv);
     }
 
     //! \brief Load the property from the JSON response and delete it from JSON
     //!
     //! If there's no top-level JSON object in the response or if there's
     //! no node with the key \p keyName, \p defaultValue is returned.
     template <typename T>
-    T takeFromJson(const QString& key, T&& defaultValue = {})
+    T takeFromJson(auto key, T&& defaultValue = {})
     {
         if (const auto& jv = takeValueFromJson(key); !jv.isUndefined())
             return fromJson<T>(jv);
@@ -432,6 +431,7 @@ private Q_SLOTS:
     template <class JobT>
     friend class JobHandle;
 
+private:
     void stop();
     void finishJob();
     QFuture<void> future();