BaseJob: Check if null in encodeIfParam

[redstrate]

If % is not inside of paramPart - like if it's empty - then std::ranges::find will return a null iterator. The rest of this if check depends on it not being null, so it segfaults when it is.

Noticed this during some random usage in NeoChat.

[KitsuneRal]

It's never supposed to be a "null" iterator (that thing doesn't really exist, to begin with), it should return paramPart.end(): https://en.cppreference.com/w/cpp/algorithm/ranges/find - something is off here.

[redstrate]

It's never supposed to be a "null" iterator (that thing doesn't really exist, to begin with), it should return paramPart.end(): https://en.cppreference.com/w/cpp/algorithm/ranges/find - something is off here.

That is weird, maybe my debugger is lying to me :D Let me re-create the crash again, but maybe it's related to paramPart being empty?

[KitsuneRal]

Ouch. That might be, the comparison with end() - 3 may go off in that case.

Okay, I actually can rewrite it with a regex, QRegularExpression precompiles itself anyway, so performance-wise it should be about the same, and the readability is better.

[redstrate]

🤦 yeah, my debugger visualization showed it as a QChar* but that's just what's inside of the iterator. You're right that it's actually the end.

Okay, I actually can rewrite it with a regex, QRegularExpression precompiles itself anyway, so performance-wise it should be about the same, and the readability is better.

Yeah that sounds even better!

[KitsuneRal]

For posterity - decent people unlike me use std::distance to check the distance from end()... aanyways, going with the regex in this case.