There's always place for more fixes #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in #799, only accidentally passing through tests.
KitsuneRal
added
bug/fix
|
The name is bad: a connection logged in via assumeIdentity() is perfectly usable yet doesn't necessarily have login flows loaded as the funciton implementation assumes.
Will be used in the next commit to rewrite TestOlmAccount.
In some situations Synapse takes a lot of time and sometimes even fails to respond to a request at once; to alleviate that, most timeouts are increased from 10 to 40 seconds, to give time for a retry. And to unify the waiting code, Quotient::waitForFuture() is introduced that internally uses QTest::qWaitFor() that is more lightweight than QSignalSpy.
These APIs are practically internal; the change is meant to streamline adding an account, assuming that both the identity and the access token arrive to these classes at the same time (e.g. see Connection::completeSetup()).
1. Mock connections no more use ConnectionEncryptionData::setup(), just initialise the object directly. There's not that much work, and it's entirely independent from what CED::setup() normally does. 2. Clearing the database has moved from Connection::P::loginToServer() to CED::setup(); the previous logic almost never worked because encryptionData is usually initialised asynchronously now, and even in the rare asynchoronous cases the clearing happened at the wrong moment - after the first save of the newly initialised Olm account.
KitsuneRal
force-pushed
the
kitsune/fixes-more-fixes
branch
from
9313820
to
1557a1d
Compare
TobiasFella
reviewed
Sep 20, 2024
KitsuneRal
commented
Sep 20, 2024
KitsuneRal
force-pushed
the
kitsune/fixes-more-fixes
branch
from
36e46b2
to
0cf7293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes, and I also accidentally rewrote
TestOlmAccountwith futures while doing the fixes.