Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's always place for more fixes #803

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Commits on Sep 18, 2024

  1. Room::updateData(): fix a dangling pointer

    This was introduced in #799, only accidentally passing through tests.
    KitsuneRal committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    543d208 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2974ad View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Deprecate Connection::isUsable()

    The name is bad: a connection logged in via assumeIdentity() is
    perfectly usable yet doesn't necessarily have login flows loaded as the
    funciton implementation assumes.
    KitsuneRal committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bd744de View commit details
    Browse the repository at this point in the history
  2. Templated BaseJob::run()

    Will be used in the next commit to rewrite TestOlmAccount.
    KitsuneRal committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ff23038 View commit details
    Browse the repository at this point in the history
  3. TestOlmAccount: rewrite with futures; ease timeouts

    In some situations Synapse takes a lot of time and sometimes even fails
    to respond to a request at once; to alleviate that, most timeouts are
    increased from 10 to 40 seconds, to give time for a retry. And to unify
    the waiting code, Quotient::waitForFuture() is introduced that
    internally uses QTest::qWaitFor() that is more lightweight than
    QSignalSpy.
    KitsuneRal committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    f737df7 View commit details
    Browse the repository at this point in the history
  4. Tweaks to ConnectionData and NAM APIs

    These APIs are practically internal; the change is meant to streamline
    adding an account, assuming that both the identity and the access token
    arrive to these classes at the same time (e.g. see
    Connection::completeSetup()).
    KitsuneRal committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    57e58c9 View commit details
    Browse the repository at this point in the history
  5. Refactor post-login connection setup

    1. Mock connections no more use ConnectionEncryptionData::setup(), just
       initialise the object directly. There's not that much work, and it's
       entirely independent from what CED::setup() normally does.
    2. Clearing the database has moved from Connection::P::loginToServer()
       to CED::setup(); the previous logic almost never worked because
       encryptionData is usually initialised asynchronously now, and even
       in the rare asynchoronous cases the clearing happened at the wrong
       moment - after the first save of the newly initialised Olm account.
    KitsuneRal committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    8c42c2f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    95c2017 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix Sonar warnings

    KitsuneRal committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c6110cd View commit details
    Browse the repository at this point in the history
  2. Typo fix

    KitsuneRal committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    aa95ac1 View commit details
    Browse the repository at this point in the history
  3. Fix building with Xcode

    KitsuneRal committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0cf7293 View commit details
    Browse the repository at this point in the history