Releasing 0.9 RC #804
Merged
Releasing 0.9 RC #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
added
enhancement
|
Both thumbnail and full download.
It is a profoundly invalid case when a tracked device has either an empty id or invalid/inexistent keys. Previously there was a Q_ASSERT guarding that; arguably, it's better to just clean away that kind of stuff from the database if it's encountered, and continue operating.
KitsuneRal
force-pushed
the
release-0.9-rc
branch
from
145923a
to
4b2e394
Compare
TobiasFella
approved these changes
Sep 22, 2024
Closed
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires a review as I entirely forgot to update to Matrix pre-1.12. And this update led to some API breakage, covered by
Connection::joinRoom()in case of joining but still there for knocking and push rules.