-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement mean occupation and get coherence functions #343
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 93.14% 93.33% +0.19%
==========================================
Files 41 41
Lines 2684 2762 +78
==========================================
+ Hits 2500 2578 +78
Misses 184 184 ☔ View full report in Codecov by Sentry. |
Please follow the checklist above. You can change this PR into draft PR before you think it is ready. Otherwise it will trigger the CI pipeline everytime when you update the branch |
To change a PR to draft PR, you can follow the steps here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request |
You included also commits of other PRs. Could you just rebase and leaving only your commits? Tell me if you don't know how to do it, in the worst case I should be able to do it directly here. |
c9034a5
to
69ccc2d
Compare
69ccc2d
to
29cae76
Compare
Yes sorry, I didn't notice when I did the rebase. |
Checklist
Thank you for contributing to
QuantumToolbox.jl
! Please make sure you have finished the following tasks before opening the PR.make test
.julia
formatted by running:make format
.docs/
folder) related to code changes were updated and able to build locally by running:make docs
.CHANGELOG.md
should be updated (regarding to the code changes) and built by running:make changelog
.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Includes functions
mean_occupation
and changesget_coherence
.Related issues or PRs
Implement #340
Additional context