Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement mean occupation and get coherence functions #343

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

labay11
Copy link

@labay11 labay11 commented Dec 8, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Includes functions mean_occupation and changes get_coherence.

Related issues or PRs

Implement #340

Additional context

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (270d3f6) to head (29cae76).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   93.14%   93.33%   +0.19%     
==========================================
  Files          41       41              
  Lines        2684     2762      +78     
==========================================
+ Hits         2500     2578      +78     
  Misses        184      184              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang ytdHuang linked an issue Dec 9, 2024 that may be closed by this pull request
@ytdHuang
Copy link
Member

Please follow the checklist above.

You can change this PR into draft PR before you think it is ready.

Otherwise it will trigger the CI pipeline everytime when you update the branch

@labay11 labay11 changed the title implement mean occupation and get coherence functions Draft: implement mean occupation and get coherence functions Dec 10, 2024
@ytdHuang
Copy link
Member

@labay11 labay11 marked this pull request as draft December 11, 2024 06:44
@labay11 labay11 marked this pull request as ready for review December 22, 2024 18:53
@labay11 labay11 changed the title Draft: implement mean occupation and get coherence functions Implement mean occupation and get coherence functions Dec 22, 2024
@albertomercurio
Copy link
Member

You included also commits of other PRs. Could you just rebase and leaving only your commits? Tell me if you don't know how to do it, in the worst case I should be able to do it directly here.

@labay11 labay11 force-pushed the 340-mean-occupation branch from c9034a5 to 69ccc2d Compare December 23, 2024 08:42
@labay11 labay11 force-pushed the 340-mean-occupation branch from 69ccc2d to 29cae76 Compare December 23, 2024 08:44
@labay11
Copy link
Author

labay11 commented Dec 23, 2024

Yes sorry, I didn't notice when I did the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility functions for bosonic states
3 participants