Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed cli not checking relative global.css correctly #1003

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Nov 4, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

the cli asks for a root folder and global.css location, but it doesn't check the css location relative to the root.

This fixes it

Checklist:

Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 6e6a8b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
qwik-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from 132283a to d015aeb Compare November 4, 2024 16:54
Copy link

pkg-pr-new bot commented Nov 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@1003
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@1003
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@1003
pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@1003

commit: 6e6a8b1

@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from d015aeb to 5e9ac1f Compare November 4, 2024 16:56
@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from 5e9ac1f to f670e69 Compare November 4, 2024 17:14
@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from 616b0cf to 8953ab8 Compare November 4, 2024 17:20
@shairez shairez marked this pull request as draft November 11, 2024 21:47
@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from 0faa1d1 to 0c3404d Compare November 13, 2024 12:23
@shairez shairez force-pushed the pr-fix-cli-for-different-root branch from 0c3404d to 6e6a8b1 Compare November 13, 2024 12:59
@shairez shairez marked this pull request as ready for review November 13, 2024 13:54
@shairez shairez merged commit ea74696 into main Nov 13, 2024
6 checks passed
@shairez shairez deleted the pr-fix-cli-for-different-root branch November 13, 2024 13:55
@shairez shairez self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant