Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking member info for a user not in the current guild doesn't work #2

Open
eritbh opened this issue Jul 30, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@eritbh
Copy link
Member

eritbh commented Jul 30, 2021

The page loads forever, because the call for member info 404s. To do something sensible in this situation, we need to do r-anime/misato#38, but in the meantime we should at least fall back to displaying a user ID or something if we have literally nothing else to show there.

It may make sense to split the user info (name/id/avatar) display and the note/warn/etc display into their own components, each relying on a different set of requests to get the required info. We could also make the API return this info much more cleanly, but that's kinda a lot of effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant