Refactor read #79
Merged
Refactor read #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can read PLAIN, uncompressed INT32 columns with not too many pages.
There is still a lot of repetition, but maybe it can't be avoided. In general the current structure looks workable.
Just in case.
Cannot test this currently.
Cannot test this currently.
Latter is untested currently.
Almost ready for optional columns.
Looks pretty good now
Almost there.
This is a bit too slow and we'll want to do the reads in place instead...
No need to create a SEXP for the metadata.
(Incomplete.)
Need to try()-catch() wrap C++ code within R_UnwindPortect(), otherwise it crashes.
So check is clean.
This will be configurable later.
This is a workaround until we have a more principled way of specifying the R schema in `read_parquet()`.
Do not remove data, skip skip it.
Switching over to new reader in all tests, gradually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of Parquet reader.