New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_character() always permits NA values #1724

Open

JosiahParry opened this issue Jul 1, 2024 · 1 comment · May be fixed by #1745

Labels

tidy-dev-day 🤓

JosiahParry commented Jul 1, 2024

i would like to ensure that check_character() does not permit NA values. However, it always allows them.

source("https://raw.githubusercontent.com/r-lib/rlang/main/R/standalone-obj-type.R")
source("https://raw.githubusercontent.com/r-lib/rlang/main/R/standalone-types-check.R")

# confirm that i have greater than 1.1
packageVersion("rlang")
#> [1] '1.1.3'

# import rlang
library(rlang)

check_character(c("a", NA, "c"), allow_na = FALSE)

The text was updated successfully, but these errors were encountered:

lionel- added the tidy-dev-day 🤓 label

Contributor

teunbrand commented Jul 11, 2024

I'd like to flag that the same problem exists for check_logical().

martaalcalde mentioned this issue

add allow_na argument to check character() #1742

Merged

olivroy linked a pull request

that will close this issue

Add allow_empty to check_logical() and check_character() #1745

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment