Use modern x-r-run convention
#1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
approved these changes
Jan 25, 2024
DavisVaughan
force-pushed
the
feature/x-r-run
branch
from
75eaf74
to
356c122
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in rstudio/rstudio#12096
I think this has been out long enough that it would be ok to move to it unconditionally? I'm not sure if a release version of RStudio without
x-r-runsupport was ever released, if so it would have been released between June->Oct of 2022 (based on looking at commit history), so that's a 4 month window where an RStudio release may have come out without support forx-r-run.In the worst case where it isn't supported, it just means the
last_trace()hyperlinks won't work until they upgrade RStudio I guess (that seems to be all it is used for)