Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve some of the non-API conundrum #1747

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shikokuchuo
Copy link

@shikokuchuo shikokuchuo commented Sep 1, 2024

Fixes #1707, replacing usage of SET_ENCLOS().
Fixes #1708 replacing usage of PREXPR() .
Addresses part of #1706, replacing usage of SET_FORMALS(), SET_BODY(), SET_CLOENV(), FRAME(), HASHTAB(), PRVALUE(), and PRENV().

@shikokuchuo
Copy link
Author

shikokuchuo commented Sep 2, 2024

Added a commit that fixes more of these (updated message above).

@lionel-
Copy link
Member

lionel- commented Sep 9, 2024

Thanks Charlie, I have some ongoing branches that I'll have to merge first (e.g. main...feature/api-find-var) before looking at this, but not in the very short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PREXPR() usage (as much as we can) Remove SET_ENCLOS() usage
2 participants