remove dependencies

r-lib · May 1, 2024 · 69b6e10 · 69b6e10
1 parent b8fb5f1
commit 69b6e10
Show file tree

Hide file tree

Showing 12 changed files with 16 additions and 306 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -13,12 +13,8 @@ Depends:
     R (>= 4.0.0)
 Imports: 
     cli (>= 3.4.0),
-    Matrix,
-    rlang (>= 1.1.0),
-    tibble,
-    vctrs
+    rlang (>= 1.1.0)
 Suggests: 
-    rsparse,
     testthat (>= 3.0.0),
     withr
 Config/Needs/website: rmarkdown

diff --git a/NAMESPACE b/NAMESPACE
@@ -1,14 +1,5 @@
 # Generated by roxygen2: do not edit by hand
 
-S3method(format,sparse_vector)
-S3method(vec_arith,sparse_vector)
-S3method(vec_math,sparse_vector)
-S3method(vec_ptype_abbr,sparse_vector)
 export(new_sparse_real)
-export(new_sparse_vector)
-export(sparse_to_tibble)
-export(sparse_vector)
-export(tibble_to_sparse)
 import(rlang)
-import(vctrs)
 useDynLib(sparsevctrs, .registration = TRUE)
diff --git a/R/altrep.R b/R/altrep.R
@@ -56,7 +56,18 @@ new_sparse_real <- function(value, position, length) {
   }
 
   if (!is.integer(position)) {
-    position <- vec_cast(position, integer())
+    if (any(round(position) != position)) {
+      offenders <- which(round(position) != position)
+
+      cli::cli_abort(
+        c(
+          x = "{.arg position} must contain integer values.",
+          i = "Non-integer values at index: {offenders}."
+        )
+      )
+    }
+
+    position <- as.integer(position)
   }
 
   len_value <- length(value)

diff --git a/R/convert.R b/R/convert.R
diff --git a/R/sparsevctrs-package.R b/R/sparsevctrs-package.R
@@ -1,12 +1,8 @@
 #' @keywords internal
 "_PACKAGE"
 
-#' Internal vctrs methods
-#'
-#' @import vctrs
 #' @import rlang
 #' @keywords internal
-#' @name sparsevctrs-vctrs
 NULL
 
 ## usethis namespace: start

diff --git a/R/vector.R b/R/vector.R
diff --git a/man/new_sparse_vector.Rd b/man/new_sparse_vector.Rd
diff --git a/man/sparse_to_tibble.Rd b/man/sparse_to_tibble.Rd
diff --git a/man/sparse_vector.Rd b/man/sparse_vector.Rd
diff --git a/man/sparsevctrs-vctrs.Rd b/man/sparsevctrs-vctrs.Rd
diff --git a/man/tibble_to_sparse.Rd b/man/tibble_to_sparse.Rd
diff --git a/tests/testthat/_snaps/altrep.md b/tests/testthat/_snaps/altrep.md
@@ -45,8 +45,8 @@
       new_sparse_real(1, 1.5, 1)
     Condition
       Error in `new_sparse_real()`:
-      ! Can't convert from `position` <double> to <integer> due to loss of precision.
-      * Locations: 1
+      x `position` must contain integer values.
+      i Non-integer values at index: 1.
 
 ---
 
@@ -86,7 +86,7 @@
     Code
       new_sparse_real(1, NaN, 1)
     Condition
-      Error in `if (len_position > 0 && max(position) > length) ...`:
+      Error in `if (any(round(position) != position)) ...`:
       ! missing value where TRUE/FALSE needed
 
 ---